Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

Add escapeReservedKeywords in all templates where needed #14

Merged
merged 7 commits into from
Feb 13, 2017

Conversation

djbe
Copy link
Member

@djbe djbe commented Jan 30, 2017

Fixes #3.

Only the structured/dot-syntax string templates already had this. In some places in the storyboards templates, it isn't needed to escape the identifier because "Scene" or "ViewController" is appended to it.

@AliSoftware AliSoftware self-assigned this Feb 12, 2017
Copy link
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add unit tests for that.
I mean, not really add, but just change the current fixtures so they all have at least one asset named with a reserved, and adapt the expected output to ensure it's properly escaped (and then #15 and #16 would help ensure it's valid Swift)

@djbe djbe force-pushed the feature/escapeReservedKeywords branch from 0f5fd22 to 827bb3f Compare February 12, 2017 23:46
@AliSoftware AliSoftware merged commit 7e48f18 into master Feb 13, 2017
@AliSoftware AliSoftware deleted the feature/escapeReservedKeywords branch February 13, 2017 12:27
@djbe djbe modified the milestone: 1.0.0 Feb 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants